NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Routing] Simplify importing routes defined on controller services#62302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.4fromnicolas-grekas:route-tagged

Nov 5, 2025

Merged

[Routing] Simplify importing routes defined on controller services#62302

fabpot merged 1 commit intosymfony:7.4fromnicolas-grekas:route-tagged

Nov 5, 2025

+8 −12

Conversation

Copy link

Member

nicolas-grekas commentedNov 4, 2025•
edited
Loading

Q	A
Branch?	7.4
Bug fix?	no
New feature?	no
Deprecations?	no
Issues	-
License	MIT

Fine-tuning#61492

Before:

controllers:resource:attributestype:tagged_services

After:

controllers:resource:routing.controllers

And when usingMicroKernelTrait (the default recipe), there's nothing to configure to have routes loaded from#[Route] attributes:

#config/routes.yaml# the file can be just empty from any config, and only have a comment saying what it's for

// config/routes.phpreturn Routes::config([]);

The way to opt-out from thisrouting.controllers import would be to override theKernel::configureRoutes() method.

carsonbot added Status: Needs Review Routing labels

Nov 4, 2025

carsonbot added this to the7.4 milestone

Nov 4, 2025

nicolas-grekas force-pushed theroute-tagged branch from86b8d7f to8682655Compare

November 4, 2025 13:53

nicolas-grekas commented

Nov 4, 2025

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php Outdated

		if ($fileName = (new \ReflectionObject($this))->getFileName()) {
		$routes->import($fileName,'attribute');
		}
		$routes->import('routing.controllers');

Copy link

MemberAuthor

nicolas-grekasNov 4, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the kernel being autoconfigured, it'll get therouting.controller tag once it uses a#[Route] attribute

nicolas-grekas added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" label

Nov 4, 2025

nicolas-grekas mentioned this pull request

Nov 4, 2025

Simplify routes.yamlsymfony/recipes#1470

Merged

stof reviewed

Nov 4, 2025

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php Outdated

		if ($fileName = (new \ReflectionObject($this))->getFileName()) {
		$routes->import($fileName,'attribute');
		}
		$routes->import('routing.controllers');

Copy link

Member

stofNov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this makes any route defined on a class with therouting.controller tag win over routes defined inroutes.yaml, while the existing solution respects the order of route definitions and so the current import might not be last. This could be a BC break if a project relies on such override.

And it also makes it impossible to override a route definition coming from a third-party bundle if that bundle defines a service tagged withrouting.controller. This second issue could be solved by importing thosebefore theroutes.yaml (orroutes.php) file though (but still after theroutes/*.yaml files where recipes are importing third-party routes)