Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DomCrawler] Fix converting HTML5 trees to DOM nodes#62186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Thanks for taking a second look. I have applied this PR to my live site and the unit tests are passing again, meaning the b/c break has been resolved. |
6aeeb25 intosymfony:7.4Uh oh!
There was an error while loading.Please reload this page.
| privatefunctioncopyFromHtml5ToDom(\Dom\Node$source,\DOMDocument$target):void | ||
| { | ||
| /** @var list<array{0: iterable<\Dom\Node>, 1: ?\DOMNode}> $stack */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can the key1 really be nullable ? The code does not handle null values when using it.
nicolas-grekasOct 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
right, I forgot to clean this up from a previous iteration, I'll do ahotpatch
Much better than#62180