Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Fix commands writing toSTDERR instead ofSTDOUT#62171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Fix commands writing toSTDERR instead ofSTDOUT#62171
Conversation
| { | ||
| $errorIo ??= $io->getErrorStyle(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
since$errorIo is always derived from$io->getErrorStyle(), I'd rather remove all the extra arguments added to method. That'd work, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas that would work, but creates new instances. Just tell me what you prefer, and I'll adjust the code accordingly. Thanks for the feedback.
STDERR instead ofSTDOUTMessenger commands were using getErrorOutput() for all output, causingstructured data (tables, messages) to go to STDERR instead of STDOUT.Fixessymfony#60822
e1318d2 to8c52eddComparenicolas-grekas commentedNov 6, 2025
Thank you@wazum. |
4116def intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
Fixes Messenger commands incorrectly routing all output to STDERR, preventing proper piping and redirection of structured data.
Updated commands to follow the established Symfony pattern (e.g.,
TranslationUpdateCommand,ContainerLintCommand):$io = new SymfonyStyle($input, $output)for primary output →STDOUT$errorIo = $io->getErrorStyle()for diagnostics →STDERRSTDOUT (parseable data):
STDERR (supplementary info):