Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[JsonStreamer] Remove deprecated code#62159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mtarld
Copy link
Contributor

QA
Branch?8.0
Bug fix?no
New feature?no
Deprecations?no
Issues
LicenseMIT

Remove deprecated code fromJsonStreamer.

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm surprised that there is no need to modify or delete tests, so this feature was not tested in 7.4.

@mtarldmtarldforce-pushed theminor/json-streamer-remove-deprecations branch from5a333a9 to1620e5dCompareOctober 25, 2025 08:11
@mtarld
Copy link
ContributorAuthor

Indeed,@GromNaN, tests are missing for that, I'm going to add them ASAP.

@mtarldmtarldforce-pushed theminor/json-streamer-remove-deprecations branch from1620e5d tofe6219aCompareOctober 25, 2025 09:38
alexandre-daubois added a commit that referenced this pull requestOct 25, 2025
This PR was merged into the 7.4 branch.Discussion----------[JsonStreamer] Add deprecation related tests| Q             | A| ------------- | ---| Branch?       | 7.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITAs mentionned in#62159 (review)Commits-------da24c13 [JsonStreamer] Add deprecation related tests
@GromNaNGromNaNforce-pushed theminor/json-streamer-remove-deprecations branch fromfe6219a to37495dfCompareOctober 25, 2025 11:09
@GromNaN
Copy link
Member

@mtarld I rebased your branch and reverted the commit adding tests in 7.4

mtarld reacted with thumbs up emoji

@nicolas-grekasnicolas-grekasforce-pushed theminor/json-streamer-remove-deprecations branch from37495df to9bdf13eCompareOctober 25, 2025 11:39
@nicolas-grekas
Copy link
Member

Thank you@mtarld.

@nicolas-grekasnicolas-grekas merged commit0750cf6 intosymfony:8.0Oct 25, 2025
8 of 10 checks passed
@mtarldmtarld deleted the minor/json-streamer-remove-deprecations branchOctober 25, 2025 11:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alexandre-dauboisalexandre-dauboisalexandre-daubois left review comments

@GromNaNGromNaNGromNaN approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mtarld@GromNaN@nicolas-grekas@alexandre-daubois@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp