Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[JsonStreamer] Ignore Deprecations in tests#62154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@santysisi
Copy link
Contributor

@santysisisantysisi commentedOct 24, 2025•
edited
Loading

QA
Branch?7.4
Bug fix?no
New feature?no
Deprecations?no
IssuesFix #...
LicenseMIT

While rebasing thisPR, I noticed deprecation warnings appearing in the tests. After investigation, it seems to be caused by the addition oftrigger_deprecations of this otherPR. To resolve this, I’ve added theGroup('legacy') attribute and also usedIgnoreDeprecations for the affected tests to prevent these warnings.

@santysisi
Copy link
ContributorAuthor

Im not in my computer now but I think the failure tests are not relevant in the context of the PR
anyway I will do a doble check tomorrow

@mtarld
Copy link
Contributor

Hey@santysisi, thanks for trying to fix this 🙂

Here, we should not ignore the deprecations, as they're not intended.
I think this is the way to go instead:#62158

santysisi reacted with thumbs up emojisantysisi reacted with heart emoji

@xabbuh
Copy link
Member

I agree, closing in favour of#62158, thanks for giving it a try

santysisi reacted with thumbs up emojisantysisi reacted with heart emoji

@xabbuhxabbuh closed thisOct 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

4 participants

@santysisi@mtarld@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp