NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[Notifier] Add support for`confirm` option in Slack buttons API#62039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.4fromallflame:7.4

Oct 12, 2025

Merged

[Notifier] Add support for`confirm` option in Slack buttons API#62039

fabpot merged 1 commit intosymfony:7.4fromallflame:7.4

Oct 12, 2025

+72 −4

Conversation

Copy link

Contributor

allflame commentedOct 10, 2025

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

Allow sendingconfirm option to the Slack API to allow for the confirm dialog to be triggered upon press of a button in the Slack clients

allflame requested a review fromOskarStark as acode owner

October 10, 2025 22:15

carsonbot added Status: Needs Review Feature Notifier labels

Oct 10, 2025

carsonbot added this to the7.4 milestone

Oct 10, 2025

OskarStark reviewed

Oct 11, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackActionsBlock.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/Slack/CHANGELOG.md OutdatedShow resolvedHide resolved

allflame force-pushed the7.4 branch from75785ce to7a46773Compare

October 11, 2025 07:13

OskarStark approved these changes

Oct 11, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Oct 11, 2025

xabbuh approved these changes

Oct 11, 2025

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it worth it to expand the readme around this? Or is the feature self-discoverable enough?

Copy link

ContributorAuthor

allflame commentedOct 11, 2025•
edited
Loading

Is it worth it to expand the readme around this?

I'm fine with updating the readme, if needed. I honestly tried to stick to the existing pattern in the codebase. The confirm array has very specific structure that can be described using docblock, however this seems not to be the approach through the code base, so I didnt do it here aswell. Ultimately the usage of this code requires having Slack API doc opened in another tab anyway. At least this is my experience with it

If you insist on the readme I'll add it, no problem

fabpot approved these changes

Oct 12, 2025

View reviewed changes

[Notifier] Add support forconfirm option in Slack buttons API

c9602f0

fabpot force-pushed the7.4 branch from70efc07 toc9602f0Compare

October 12, 2025 06:58

Copy link

Member

fabpot commentedOct 12, 2025

Thank you@allflame.

fabpot merged commit570cefa intosymfony:7.4

Oct 12, 2025

12 checks passed

Zarthus reviewed

Oct 12, 2025

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Slack/README.md

		'title' => ['type' => 'plaint_text', 'text' => 'Report a bug'],
		'text' => ['type' => 'plaint_text', 'text' => 'By proceeding I confirm I\'ve read the guidelines.'],
		'confirm' => ['type' => 'plaint_text', 'text' => 'Proceed'],
		'deny' => ['type' => 'plaint_text', 'text' => 'Go back to reading']