Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache][RedisTagAwareAdapter] Add Predis2 Replication Interface check#61990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromBrianMwit:fix_60050
Oct 7, 2025

Conversation

@BrianMwit
Copy link
Contributor

@BrianMwitBrianMwit commentedOct 7, 2025•
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#60050
LicenseMIT

Predis 2 moved ReplicationInterface to a different path.
Check was already added in RedisTrait:https://github.com/symfony/symfony/pull/59751/files#diff-38029e8e3e92a47fb8091876d3e8bc7fc61c2fc793cabf842ed933bf6985134c but missing from RedisTagAwareAdapter. This causes issue when when using TagAware adapter with Replicated Predis2 while it worked with Predis1
This PR add a similar check to RedisTagAwareAdapter

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Thank you@BrianMwit.

@nicolas-grekasnicolas-grekas merged commitdd2aaad intosymfony:6.4Oct 7, 2025
10 of 11 checks passed
@BrianMwitBrianMwit deleted the fix_60050 branchOctober 14, 2025 21:34
This was referencedOct 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

3 participants

@BrianMwit@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp