Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Fix discriminator class mapping with allow_extra_attributes=false#61889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromchris54721:fix/serializer-discriminator-extra-attributeOct 2, 2025
Merged
[Serializer] Fix discriminator class mapping with allow_extra_attributes=false#61889
nicolas-grekas merged 1 commit intosymfony:6.4fromchris54721:fix/serializer-discriminator-extra-attributeOct 2, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5f9b2b0 to04882d8CompareDon't we also have to patch the |
04882d8 to6b56ec9Compare@xabbuh you're right, I have patched those as well, thanks. |
src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…llow_extra_attributes=falseMake sure that the discriminator mapping type property is considered an allowed attributewhen the `AbstractNormalizer::ALLOW_EXTRA_ATTRIBUTES` context option is set to `false`.
6b56ec9 to4afa086Comparexabbuh approved these changesOct 2, 2025
Thank you@chris54721. |
b8509c7 intosymfony:6.4 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the discriminator mapping type property is considered an allowed attribute when the
AbstractNormalizer::ALLOW_EXTRA_ATTRIBUTEScontext option is set tofalse.