Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[JsonStreamer] MergePropertyMetadata
value transformers#61880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Could this be implemented with a BC layer ? The fact that the component is experimental in 7.3 allows us to do BC breaks in minor versions if needed, but I think this is a case where the BC layer is easy enough to implement. An immediate BC break is more costly for the ecosystem than a deprecation, so we should still prefer doing a deprecation. |
7417836
to24d593c
Compare24d593c
to219aa6d
Compare
This PR merges
PropertyMetadata::$streamToNativeValueTransformers
andPropertyMetadata::$nativeToStreamValueTransformers
toPropertyMetadata::$valueTransformers
.Indeed, as property metadata is computed in one way at the time (reading or writing), there is no benefit keeping a distinction between native to stream and stream to native.