NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[Console] Handle signals on text input#61878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

valx76 wants to merge3 commits intosymfony:7.4fromvalx76:feature/handle-signals-on-text-input

Closed

[Console] Handle signals on text input#61878

valx76 wants to merge3 commits intosymfony:7.4fromvalx76:feature/handle-signals-on-text-input

+108 −8

Conversation

Copy link

valx76 commentedSep 29, 2025

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues
License	MIT

QuestionHelper is blocking signals because of itsfgets/fgetc use.
This PR usesfread so signals can be dispatched in text inputs.
Since Windows is not supported by the PCNTL extension, it was working fine on this OS.

Note

This change has been tested in Windows, Linux and MacOS.

Snippet to test the behavior manually:

useSymfony\Component\Console\Attribute\Argument;useSymfony\Component\Console\Attribute\AsCommand;useSymfony\Component\Console\Command\Command;useSymfony\Component\Console\Helper\QuestionHelper;useSymfony\Component\Console\Input\InputInterface;useSymfony\Component\Console\Output\OutputInterface;useSymfony\Component\Console\Question\Question;#[AsCommand(name:'app:test')]class TestCommand{publicfunction__invoke(InputInterface$input,OutputInterface$output,        #[Argument('Mode (single / multi)')]string$mode ='single'    ):int {$question =newQuestion('Enter text:');$question->setMultiline($mode !=='single');$helper =newQuestionHelper();$result =$helper->ask($input,$output,$question);$output->writeln('Result:'.$result);return Command::SUCCESS;    }}