Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] do not cast too big floats to int#61875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromxabbuh:php-19760
Sep 29, 2025

Conversation

@xabbuh
Copy link
Member

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

the last PHP 8.5 related failure for the6.4 branch that we can fix on our end (seehttps://github.com/symfony/symfony/actions/runs/18059816827/job/51394530342#step:8:2731)

@carsonbotcarsonbot added this to the6.4 milestoneSep 29, 2025
@carsonbotcarsonbot changed the title[Form] do not cast too big floats to int[Form] do not cast too big floats to intSep 29, 2025
@stof
Copy link
Member

The whole method looks weird to me. If the value is an int that can also be represented as a float without precision loss, return the float ? Why doing that ?

@xabbuh
Copy link
MemberAuthor

The whole method looks weird to me. If the value is an int that can also be represented as a float without precision loss, return the float ? Why doing that ?

I was wondering the same but getting rid of the cast means that theNumberType will then return integers where it previously returned floats leading to several related test failures.

This piece of code was introduced in#18358 to fix#18346.

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit372d809 intosymfony:6.4Sep 29, 2025
9 of 11 checks passed
@xabbuhxabbuh deleted the php-19760 branchSeptember 29, 2025 16:56
This was referencedOct 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@stof@nicolas-grekas@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp