This PR introduces a new helperTerminalInputHelper that restores the terminal to its original state after it has been modified when reading using input. This ensures that the terminal is not broken when a terminating signal, like Ctrl-C, is received.

QuestionHelper.php disablesicanon andecho when accepting input from a selection, and disablesecho when accepting hidden input. If these are not restored before termination, the user's terminal can end up in a broken state.

Usage:

$inputHelper =newTerminalInputHelper($inputStream);// Change terminal settings then wait for input before all input reads$inputHelper->waitForInput();// Read the input then call finish to restore terminal settings and signal handlers$inputHelper->finish()

The helper creates its own signal handlers (forSIGINT,SIGQUIT, andSIGTERM) that restore the original terminal settings then call any original handler callback. If the original handler callback does not terminate the process then the current terminal settings are restored.

If there is no original signal handler callback and the signal's disposition is set to the default action (SIG_DFL), then that action is invoked by aposix_kill call.

Thefinish method restores the terminal settings and replaces the new signal handlers with the original ones.

johnstevenson requested a review fromchalasr as acode owner

September 26, 2025 17:36

carsonbot added Status: Needs Review Bug labels

Sep 26, 2025

carsonbot added this to the6.4 milestone

Sep 26, 2025

carsonbot changed the title~~Ensure terminal is usable after termination signal~~ Ensure terminal is usable after termination signal

Sep 26, 2025

johnstevenson mentioned this pull request

Sep 27, 2025

composer run: Ctrl+C leaves shell in a broken statecomposer/composer#12526

Open

Copy link

Member

chalasr commentedSep 28, 2025

Do you have a use case for using this helper in your own commands whether coming from a Symfony application or a reusable bundle? Elsewhere than in core I mean.

Copy link

ContributorAuthor

johnstevenson commentedSep 28, 2025

Do you have a use case for using this helper in your own commands...

Not at all. The helper is to fix the issues with Symfony/Console.

Copy link

ContributorAuthor

johnstevenson commentedSep 28, 2025

I've just noticed this issue#61852 (that has been closed). This PR fixes the problem described, which is having to hit Enter after a Ctrl-C to send the signal (when submitting hidden input).

Copy link

Member

chalasr commentedSep 28, 2025

Please inline back the logic into Application and QuestionHelper. Helpers in this namespace are part of Console's public API, but I can't think of a use case for this helper in userland either and I looking at it, I don't think it's worth it. Expanding the public API is a feature also while this PR is a bugfix targeting a branch that is in maintenance mode, so please do the minimum changes to fix the bug at hand. Thanks