Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Intl] Support time in generated data in currencies validity#61859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromCrovitche-1623:6.4-clean
Oct 1, 2025

Conversation

@Crovitche-1623
Copy link
Contributor

@Crovitche-1623Crovitche-1623 commentedSep 26, 2025•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

@nicolas-grekas

see#61837 (comment)

Note: This PR is a prerequisite of#61837

@nicolas-grekas
Copy link
Member

Ah, I think we should remove the TZ info, it should be implicit:+00:00 should be removed

Crovitche-1623 reacted with thumbs up emoji

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Currencies need to be updated, as it uses\DateTimeImmutable::createFromFormat('Y-m-d'):https://github.com/symfony/symfony/blob/52561f9d9de633b59834f58f47b23b77ad966a62/src/Symfony/Component/Intl/Currencies.php#L228C17-L228C61

note that if you want to omit the+00:00 TZ info, you need to force the UTC timezone when consuming it, to avoid issues for servers using a different default timezone in their php.ini.

Crovitche-1623 reacted with thumbs up emoji
@Crovitche-1623
Copy link
ContributorAuthor

Crovitche-1623 commentedSep 29, 2025•
edited
Loading

Ah, I think we should remove the TZ info, it should be implicit: +00:00 should be removed

@nicolas-grekas Ok, I'll remove the +00:00 even though I deliberately put it there to avoid any confusion with the source XML files.

@stof The methods that process themeta.php file were added in the 7.4 branch. I'll do the required changes inCurrencies in#61837 (also in 7.4) if it's ok for you as it'll be the sole place the data are used

Crovitche-1623 added a commit to Crovitche-1623/symfony that referenced this pull requestSep 29, 2025
… declaration as the timezone is missing from the format
@fabpot
Copy link
Member

Thank you@Crovitche-1623.

@fabpotfabpot merged commitd7186d2 intosymfony:6.4Oct 1, 2025
10 of 12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Crovitche-1623@nicolas-grekas@fabpot@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp