Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Validator] Add ArrayLoader and wire it in semantic configuration#61831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
+306 −109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm submitting this PR for the record, because I didn't convince myself it's worth pursuing.
Attributes apart, validation constraints can be declared using dedicated YAML or XML files.
For bundles, those files should be put in predetermined locations.
For apps, there's the
framework.validation.mapping.pathsconfig options to list them, and there is theconfig/validator/folder that's hardcoded.In#61545, we added support for configuration via attributes, thanks to
#[ExtendsValidationFor].And I then wondered: what about using plain semantic configuration for apps? That'd be better than the current alternatives, and might be more boring (in a good way) than the new attribute?
That's what this PR achieves, kind of.
BUT, I hit a wall: the structure under
metadatais recursive: constraints can list other constraints as options, recursively.And this is not nicely described using the Config component.
Which means in the end the envisioned DX is going to be poor, because of the lack of descriptive info that'd be required for nice IDE support.
I'm still submitting as food for thoughts.
TL;DR: attributes FTW :)
PS: the same chain of thoughts can be applied to serializer's metadata, related to#61563. There, I don't think the "recursive" argument applies. Yet, we should support both Validator and Serializer if we go this way IMHO. It'd be inconsistent otherwise.