Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] deprecate implicit constraint option names in YAML/XML mapping files#61791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
the failures look related Status: Needs Work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you also add tests for the deprecated feature?
53ed983 tof6a14b0Compare@GromNaN done |
| callback:[Symfony\Component\Validator\Tests\Fixtures\CallbackClass, callback] | ||
| ``` | ||
| After: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
before /after are inverted, isn't it?
UPGRADE-7.4.md Outdated
| ```xml | ||
| <classname="Symfony\Component\Validator\Tests\Fixtures\NestedAttribute\Entity"> | ||
| <optionname="callback"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is missing the<constraint name="Callback"> tag
UPGRADE-7.4.md Outdated
| ```yaml | ||
| Symfony\Component\Validator\Tests\Fixtures\NestedAttribute\Entity: | ||
| constraints: | ||
| -Callback:validateMeStatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is swapping the before and after cases
| ```xml | ||
| <classname="Symfony\Component\Validator\Tests\Fixtures\NestedAttribute\Entity"> | ||
| <optionname="callback"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is missing the<constraint name="Callback"> tag
changelog and upgrade file fixed |
Thank you@xabbuh. |
ce54488 intosymfony:7.4Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.