Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer][Mandrill] Addsubaccount to the payload#61775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@andrehoong-pixieset
Copy link
Contributor

QA
Branch?7.4
Bug fix?no
New feature?yes
Deprecations?no
IssuesN/A
LicenseMIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleAdd the subaccount paramater to the MandrillApiTransport payload Add the subaccount paramater to the MandrillApiTransport payloadSep 16, 2025
@carsonbotcarsonbot changed the title Add the subaccount paramater to the MandrillApiTransport payload[Mailer] Add the subaccount paramater to the MandrillApiTransport payloadSep 17, 2025
@OskarStarkOskarStark changed the title[Mailer] Add the subaccount paramater to the MandrillApiTransport payload[Mailer][Mandrill] Add the subaccount paramater to the payloadSep 17, 2025
@OskarStarkOskarStark changed the title[Mailer][Mandrill] Add the subaccount paramater to the payload[Mailer][Mandrill] Addsubaccount to the payloadSep 17, 2025
@OskarStark
Copy link
Contributor

Can you please add a test case? Thanks

andrehoong-pixieset reacted with thumbs up emoji

@andrehoong-pixiesetandrehoong-pixiesetforce-pushed theadd-subaccount-to-mandrill-api-transport-payload branch from713055f to4c85200CompareSeptember 17, 2025 16:31
@andrehoong-pixieset
Copy link
ContributorAuthor

Hey@OskarStark a unit test has been added to cover this!

@fabpotfabpotforce-pushed theadd-subaccount-to-mandrill-api-transport-payload branch from0f8c7bc tof5b2050CompareSeptember 19, 2025 10:30
@fabpot
Copy link
Member

Thank you@andrehoong-pixieset.

@fabpotfabpot merged commit91f8966 intosymfony:7.4Sep 19, 2025
10 of 12 checks passed
@fabpotfabpot mentioned this pull requestOct 27, 2025
@fabpotfabpot mentioned this pull requestOct 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

6 participants

@andrehoong-pixieset@carsonbot@OskarStark@fabpot@stof@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp