Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer][Sendgrid] Add support forglobal region#61758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
carsonbot commentedSep 15, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| parent::__construct(null !==$region ?\sprintf('smtp.%s.sendgrid.net',$region) :'smtp.sendgrid.net',465,true,$dispatcher,$logger); | ||
| $host ='smtp.sendgrid.net'; | ||
| if (null !==$region &&'global' !==strtolower($region)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| if (null !==$region &&'global' !==strtolower($region)) { | |
| if (null !==$region &&'global' !==$region) { |
I don't think we need to make it case insensitive.
ddb96be to9ce7d5dCompareThank you@sonnymilton. |
9b36ddc intosymfony:7.4Uh oh!
There was an error while loading.Please reload this page.
ivan-wolf commentedSep 16, 2025
Hi@sonnymilton, thank you for providing a fix to#61706! Did you also check the |
…ansport) (sonnymilton)This PR was merged into the 7.4 branch.Discussion----------[Mailer][Sendgrid] Add support for `global` region (api transport)| Q | A| ------------- | ---| Branch? | 7.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues |Fix#61706| License | MITRelated to#61706 and#61758Add support for `global` region (`SendgridApiTransport`)Commits-------8eb5a45 [Mailer][Sendgrid] Add support for `global` region (api transport)
This PR ensures that when the
globalregion is provided toSendgridSmtpTransport,the correct host
smtp.sendgrid.netis used.Previously, passing
region=globalresulted in the host being built assmtp.global.sendgrid.net, which does not exist.Why
sendgrid+smtp://KEY@default?region=globalfailed to connect.smtp.sendgrid.net(same as when no region is provided).
How
SendgridSmtpTransportto special-case theglobalregion.