Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TypeInfo] Fix issue with merging union type with a nullable union type#61728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@matijn-made
Copy link
Contributor

@matijn-madematijn-made commentedSep 11, 2025•
edited by OskarStark
Loading

QA
Branch?7.3
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

The new TypeInfo component doesn't handle this situation correctly.
Found this after upgrading to 7.3, where the PropertyInfo now calls TypeInfo, given this docblock:

/** * @phpstan-type NullableUnionType = string|int|null * @phpstan-type UnionWithNullableUnionType = float|NullableUnionType */

In 7.3 it will throwSymfony\Component\TypeInfo\Exception\InvalidArgumentException: Cannot set "Symfony\Component\TypeInfo\Type\UnionType" as a "Symfony\Component\TypeInfo\Type\UnionType" part. exception.
This PR makes sure that nullable union types are also merged, before being passed to a new UnionType

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Contributor

@mtarldmtarld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, thanks@matijn-made !

@nicolas-grekas
Copy link
Member

Thank you@matijn-made.

@nicolas-grekasnicolas-grekas merged commitf4e417a intosymfony:7.3Sep 11, 2025
10 of 11 checks passed
@fabpotfabpot mentioned this pull requestSep 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@mtarldmtarldmtarld approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

6 participants

@matijn-made@carsonbot@nicolas-grekas@stof@OskarStark@mtarld
[8]ページ先頭
©2009-2025 Movatter.jp