Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Replace __sleep/wakeup() by __(un)serialize() for throwing and internal usages#61727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+344 −480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ef6aeb6
tof068888
Comparef068888
toef4e3d6
Compare92a6bd1
intosymfony:6.4 9 of 12 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR replaces
__sleep
/wakeup()
by__(un)serialize()
, for throwing and internal usages.This follows the merge ofphp/php-src#19435
While this change on 8.5 might be reverted (seehttps://wiki.php.net/rfc/soft-deprecate-sleep-wakeup), we can still remove all those cases.
This DOES NOT replace all use cases of
__sleep
/wakeup()
. We did so already on branch 7.4, but doing it on branch 6.4 is another story. This would basically be way to risky IMHO, with a bunch of non-trivial code to add just to fix the deprecation.My recommendation for those remaining use cases is to ignore the deprecation. By the time ppl will move to PHP 8.5, they will also move away from Symfony 6.4
I'll submit another PR to the phpunit-bridge for that.
For the record, here is the list of files/classes that cannot be "just" migrated to
__(un)serialize()
(I'll let the reader wonder about how they could be - and compare their ideas to what we did in 7.4):