Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Fix optimizing ClassExistenceResource#61615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
1778811 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
| } | ||
| if ($resourceinstanceof ClassExistenceResource) { | ||
| $class=$resource->getResource(); | ||
| if (!$resourceinstanceof ClassExistenceResource) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should we extract the check of ClassExistenceResource being in vendors into a private method instead of this early check of any other type ? It might reduce the risk of mistakes when wanting to optimize other Resource implementations in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's see in the future :)
Uh oh!
There was an error while loading.Please reload this page.
Per@stof review at#57948 (review)
Best reviewedignoring whitespaces.