Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Add metadata about currencies' validity dates#61556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cb75fce to4a85bb3Comparenicolas-grekas commentedAug 29, 2025
Thank you@Crovitche-1623. |
8a54b6e intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
| if ($unsigned64 >= (1 <<63)) { | ||
| $unsigned64 -= (1 <<64); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The psalmjob fails since this commit due to a bug:vimeo/psalm#11209
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This condition is not necessary and the fix is not working. It can be removed:#61681
…tor::icuPairToDate` (GromNaN)This PR was merged into the 6.4 branch.Discussion----------[Intl] Remove incorrect condition in `CurrencyDataGenerator::icuPairToDate`| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#61556 (comment)| License | MITRemove a useless condition that breaks psalm analysis.- `1 << 63 === PHP_INT_MIN` we cannot have a lower int value- `1 << 64 === 0` so the removing this value doesn't change anythingFix psalm crash due to bugvimeo/psalm#11209When `PHP_INT_MIN - 1`, the value is converted to a float that breaks the type system of psalmhttps://github.com/vimeo/psalm/blob/279f3eab037923d3f9d3ea3de1a16b425653e30c/src/Psalm/Internal/Type/SimpleAssertionReconciler.php#L2073Dealing with timestamp `>= (1 << 62)/1000` will be necessary when we read [year 146140482](https://3v4l.org/AAKNt).Commits-------7779ac1 [Intl] Remove incorrect condition in CurrencyDataGenerator::icuPairToDate
This backports intl data from#61431 to 6.4
This also syncs the ICU compilation scripts with 7.4.
This allows generating ICU data once on 6.4 and not have to care about running that again on higher branches.