NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[TypeInfo] Prevent interfaces extending BackedEnum to be treated as BackedEnums#61543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.3fromettoredn:fix/typeinfo-backedenum-interface

Aug 28, 2025

Merged

[TypeInfo] Prevent interfaces extending BackedEnum to be treated as BackedEnums#61543

nicolas-grekas merged 1 commit intosymfony:7.3fromettoredn:fix/typeinfo-backedenum-interface

Aug 28, 2025

Conversation

Copy link

Contributor

ettoredn commentedAug 27, 2025•
edited
Loading

Q	A
Branch?	7.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

Given

interface DummyBackedEnumInterface extends \BackedEnum{}

TypeFactoryTrait.php::enum():249 throws exceptionClass "DummyBackedEnumInterface" is not an enum trying to get the backing type, which is not defined.

    public static function enum(string $className, ?BuiltinType $backingType = null): EnumType    {        if (is_subclass_of($className, \BackedEnum::class)) {            if (null === $backingType) {                $reflectionBackingType = (new \ReflectionEnum($className))->getBackingType(); // <-- throws                 $typeIdentifier = TypeIdentifier::INT->value === (string) $reflectionBackingType ? TypeIdentifier::INT : TypeIdentifier::STRING;                $backingType = new BuiltinType($typeIdentifier);            }            return new BackedEnumType($className, $backingType);        }        return new EnumType($className);    }

This PR is meant as a fix. Upgrading to 7.3 broke my project because of this issue.

The open problem is how TypeInfo should handle BackedEnums that have no backing type defined. Besides interfaces, I'm not aware of any other way this can happen.

An alternative would be to extendBackedEnumType to support undefined backing type.

Copy link

carsonbot commentedAug 27, 2025

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot