NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection] add routing.controller to the list of known DI tags#61530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.4fromxabbuh:pr-61492

Aug 26, 2025

Merged

[DependencyInjection] add routing.controller to the list of known DI tags#61530

nicolas-grekas merged 1 commit intosymfony:7.4fromxabbuh:pr-61492

Aug 26, 2025

Conversation

Copy link

Member

xabbuh commentedAug 26, 2025

Q	A
Branch?	7.4
Bug fix?	no
New feature?	no
Deprecations?	no
Issues
License	MIT

re-reading#61492 I wonder if we don't have to add the new tag to this list

carsonbot added Status: Needs Review DependencyInjection labels

Aug 26, 2025

carsonbot added this to the7.4 milestone

Aug 26, 2025

Copy link

Member

Adding the tag in the list will avoid having it reported as unused tag in the container logs in case the new loader service gets removed due to older dependencies.
Given thatsymfony/routing is a mandatory dependency, that special case (usingsymfony/routing 7.3 with FrameworkBundle 7.4+) is the only case where it could have an impact.