Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Don't fallback to default serializer if tags specify a named one#61526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bea29a2 toe442a38Comparenicolas-grekas approved these changesAug 26, 2025
fabpot approved these changesAug 26, 2025
Member
fabpot commentedAug 26, 2025
Thank you@HypeMC. |
8ec0d38 intosymfony:7.3 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
GromNaN added a commit to symfony/monolog-bundle that referenced this pull requestSep 24, 2025
… or handler (HypeMC)This PR was merged into the 3.x branch.Discussion----------Don't add processor to all loggers if tags specify a channel or handlerSimilar tosymfony/symfony#61526.When you add a custom processor to a specific channel or handler, it gets added to **all** channels because `ProcessorInterface` is [registered for autoconfiguration](https://github.com/symfony/monolog-bundle/blob/58b98dcf5d3c818679f078d514284b16cc986d34/DependencyInjection/MonologExtension.php#L106-L108).Here's a simple example:```php#[AsMonologProcessor('my_channel')]final class MyProcessor implements ProcessorInterface{ public function __invoke(LogRecord $record) {}}```You'd expect this processor to be registered only for `my_channel`, but due to autoconfiguration it's added to every channel.The workaround is to disable autoconfiguration and add an explicit tag.```yamlservices: App\MyProcessor: autoconfigure: false tags: - monolog.processor: { channel: 'my_channel' }```This PR ensures a processor is not added to all channels when an explicit channel or handler is configured.Commits-------09b4bae Don't add processor to all loggers if tags specify a channel or handler
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to#61511.