Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Routing][Serializer] Deprecate annotation aliases and getters and setters in favor of public properties on attributes#61487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedAug 21, 2025
edited
Loading

QA
Branch?7.4
Bug fix?no
New feature?no
Deprecations?yes
Issues-
LicenseMIT

Let's remove more needless boilerplate.

These deprecations shouldn't affect anyone since I don't expected other code than ours to read these attributes.

Note that I don't make properties onRoute readonly because of the existing setters.
(Note also that having readonly on the other attribute properties isn't useful in pragmatic terms, that's mostly pedantic ;) )

…tters in favor of public properties on attributes
@carsonbotcarsonbot added this to the7.4 milestoneAug 21, 2025
@nicolas-grekasnicolas-grekas merged commited38673 intosymfony:7.4Aug 21, 2025
12 checks passed
@nicolas-grekasnicolas-grekas deleted the r-deprec-attr-get-set branchAugust 21, 2025 14:02
nicolas-grekas added a commit that referenced this pull requestAug 21, 2025
…tters and setters in favor of public properties on attributes (nicolas-grekas)This PR was merged into the 8.0 branch.Discussion----------[Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes| Q             | A| ------------- | ---| Branch?       | 8.0| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Issues        | -| License       | MITFollows#61487Commits-------153ae98 [Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes
Kocal added a commit to symfony/ux that referenced this pull requestAug 22, 2025
This PR was merged into the 2.x branch.Discussion---------- Fix highest-deps job| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Docs?         | no <!-- required for new features -->| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT<!--Replace this notice by a description of your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->Related tosymfony/symfony#61488 &symfony/symfony#61487Commits-------0d51a72 Fix highest-deps job
@MatTheCat
Copy link
Contributor

A changelog has been removed by this PR:https://github.com/symfony/symfony/pull/61487/files#diff-e12f46870a296882778d874e36f57ed916484332b8d3ad0b349f5297712071e9L80 not sure if it was intentional.

@xabbuh
Copy link
Member

I guess it should be added back

@xabbuh
Copy link
Member

xabbuh commentedAug 27, 2025
edited
Loading

Re-reading the linked PR again I think the current way is correct. The changelog entries added there mention that all the getter and setter methods are deprecated (which includesgetEnv() andsetEnv()). ThegetEnvs() andsetEnvs() methods added here have been removed for the same reason.

MatTheCat reacted with thumbs up emoji

This was referencedOct 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@MatTheCat@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp