Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Routing][Serializer] Deprecate annotation aliases and getters and setters in favor of public properties on attributes#61487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…tters in favor of public properties on attributes
ed38673 intosymfony:7.4Uh oh!
There was an error while loading.Please reload this page.
…tters and setters in favor of public properties on attributes (nicolas-grekas)This PR was merged into the 8.0 branch.Discussion----------[Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes| Q | A| ------------- | ---| Branch? | 8.0| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues | -| License | MITFollows#61487Commits-------153ae98 [Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes
This PR was merged into the 2.x branch.Discussion---------- Fix highest-deps job| Q | A| ------------- | ---| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Docs? | no <!-- required for new features -->| Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT<!--Replace this notice by a description of your feature/bugfix.This will help reviewers and should be a good start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (seehttps://symfony.com/bc).-->Related tosymfony/symfony#61488 &symfony/symfony#61487Commits-------0d51a72 Fix highest-deps job
A changelog has been removed by this PR:https://github.com/symfony/symfony/pull/61487/files#diff-e12f46870a296882778d874e36f57ed916484332b8d3ad0b349f5297712071e9L80 not sure if it was intentional. |
I guess it should be added back |
xabbuh commentedAug 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Re-reading the linked PR again I think the current way is correct. The changelog entries added there mention that all the getter and setter methods are deprecated (which includes |
Uh oh!
There was an error while loading.Please reload this page.
Let's remove more needless boilerplate.
These deprecations shouldn't affect anyone since I don't expected other code than ours to read these attributes.
Note that I don't make properties on
Routereadonly because of the existing setters.(Note also that having readonly on the other attribute properties isn't useful in pragmatic terms, that's mostly pedantic ;) )