Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Intl] Take timezoneTypes’ ianaMap into account#61426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromMatTheCat:ticket_61289
Aug 19, 2025

Conversation

@MatTheCat
Copy link
Contributor

@MatTheCatMatTheCat commentedAug 14, 2025•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#61289
LicenseMIT

Timezones name are CLDR canonical’s which “[are] based on very old version of the time zone database” (source). This means that IANA canonical timezones won’t appear if they changed, so this PR adds them.

EDIT: I see tests run against ICU 76.1; should I update everything to 77.1?

@ro0NL
Copy link
Contributor

i'd do the icu update first yes

for this PR it will also impact the timezone form type, but i dont think it matters much

@MatTheCat
Copy link
ContributorAuthor

MatTheCat commentedAug 15, 2025•
edited
Loading

My mistake, data were updated by#60157; I needed to order the test’s zones and update the timezone <=> country mapping. Should be good now.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm just wondering: shouldn't we merge this to 6.4?

@stof
Copy link
Member

Given that we update the ICU data in the LTS version, fixes to the data generator should indeed be merged in 6.4, otherwise the next update will still use the old data generator (until the EOL of 6.4)

@nicolas-grekasnicolas-grekas modified the milestones:7.4,6.4Aug 19, 2025
@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commitab6a579 intosymfony:6.4Aug 19, 2025
8 of 12 checks passed
@MatTheCatMatTheCat deleted the ticket_61289 branchAugust 19, 2025 14:05
@fabpotfabpot mentioned this pull requestAug 29, 2025
@fabpotfabpot mentioned this pull requestAug 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

Timezone Asia/Calcutta deprecated

5 participants

@MatTheCat@ro0NL@stof@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp