Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Process] Enhance hasSystemCallBeenInterrupted function for non-english locale#61401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromchristianseel:patch-2
Aug 14, 2025

Conversation

christianseel
Copy link
Contributor

@christianseelchristianseel commentedAug 13, 2025
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesRelated:PHPMailer/PHPMailer#3183
LicenseMIT

We've been facing an issue with PHPMailer (PHPMailer/PHPMailer#3183) wherestream_select() returns false, but because our application usessetlocale(LC_ALL, 'de_DE.UTF-8'), the PHP warning doesNOT contain the string'interrupted system call' which results in unexpected behavior (no retry happening).

We did found a fix for this:PHPMailer/PHPMailer#3193

I received a great hint by@teefax – who pointed out that the stream_select(): Unable to select part of the php warning message is not translated for other locales. Only the interrupted system call part is translated.

That Unable to select is followed by an error number in square brackets. However that number can be different based on the operating system of the server. But PHP has a constantSOCKET_EINTR for that.

So the recommendation is to check for the SOCKET_EINTR constant which is defined under Windows and UNIX-like platforms (if available on the platform) and use that with the other english warning text to catch those interrupted system calls for non-english locale applications.

I left the existing check to avoid any potential unknown breaking change and extended the if-condition.

As I known Symfony was using a similar approach, I'm recommending to apply this enhancement to the "interrupted check" as well.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleEnhance hasSystemCallBeenInterrupted function for non-english locale Enhance hasSystemCallBeenInterrupted function for non-english localeAug 13, 2025
@carsonbotcarsonbot changed the title Enhance hasSystemCallBeenInterrupted function for non-english locale[Process] Enhance hasSystemCallBeenInterrupted function for non-english localeAug 13, 2025
@christianseel
Copy link
ContributorAuthor

Deprecation andFeature labels have been added incorrectly because of a mistake in the first PR description version. I updated the description, but someone needs to remove the labels please. (sorry!)

@OskarStark
Copy link
Contributor

OskarStark commentedAug 14, 2025
edited
Loading

Removed the labels, no problem 😉

@nicolas-grekas
Copy link
Member

Thank you@christianseel.

christianseel, OskarStark, and marcuspoehls reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commitb0687c9 intosymfony:6.4Aug 14, 2025
2 checks passed
This was referencedAug 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@santysisisantysisisantysisi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@christianseel@carsonbot@OskarStark@nicolas-grekas@santysisi

[8]ページ先頭

©2009-2025 Movatter.jp