Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Fix expected exception message to include quotes around "http(s)://"#61360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedAug 7, 2025
ContributorAuthor
santysisi commentedAug 7, 2025
I think the errors aren't relevant in the context of this PR |
Member
xabbuh commentedAug 8, 2025
Good catch, thanks@santysisi. |
fe8a2de intosymfony:7.4 16 of 20 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
This PR updates a test assertion to match the actual exception message being thrown in the code.
The test was previously expecting the message:
<failingType> endpoint needs to be provided without http(s)://.But the actual exception thrown is:
<failingType> endpoint needs to be provided without "http(s)://".The discrepancy caused the test to fail. This fix ensures the test correctly reflects the expected output, including the necessary double quotes.
Changes made
$this->expectExceptionMessage(...)to include the quoted string"http(s)://".No other logic or behavior has been changed.
References
The exception is thrown with
"http(s)://"in quotes.The test incorrectly expects the message without quotes.