Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] [Table] Don't split grapheme clusters#61319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@schlndh
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

This change prevents splitting of grapheme clusters due to wrapping in Table. The emoji consists of multiple code points, soCodePointString chunked it into multiple pieces and wordrap then split them into separate lines. E.g.:

--- Expected+++ Actual@@ @@-'👩‍🌾'+'👩+‍+🌾'

@carsonbotcarsonbot added this to the6.4 milestoneAug 4, 2025
@carsonbotcarsonbot changed the title[Console][Table] Don't split grapheme clusters[Console] [Table] Don't split grapheme clustersAug 4, 2025
@schlndhschlndhforce-pushed thefix-dontSplitGraphemeCluster branch from965e5cf toc258c19CompareAugust 4, 2025 08:03
@nicolas-grekas
Copy link
Member

Thank you@schlndh.

schlndh reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitcfe2fcc intosymfony:6.4Aug 4, 2025
10 of 11 checks passed
@schlndhschlndh deleted the fix-dontSplitGraphemeCluster branchAugust 4, 2025 09:45
This was referencedAug 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@schlndh@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp