Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ObjectMapper] read source metadata before transform#61310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 2 commits intosymfony:7.3fromsoyuka:fix-61027
Aug 12, 2025

Conversation

@soyuka
Copy link
Contributor

QA
Branch?7.3
Bug fix?yes
New feature?no
Deprecations?no
Issuesfixes#61027
LicenseMIT

@nicolas-grekas
Copy link
Member

Needs to account for#61027 (comment)? /cc@rvanlaak

@rvanlaak
Copy link
Contributor

Needs to account for#61027 (comment)? /cc@rvanlaak

Will verify this within the hour, and potentially provide a commit with a test case to cherry-pick.

@rvanlaak
Copy link
Contributor

@soyuka@nicolas-grekas added PRsoyuka#2 with a test case and fix for#61027 (comment)

@nicolas-grekas
Copy link
Member

Thank you@soyuka.

@nicolas-grekasnicolas-grekas merged commit50cd48c intosymfony:7.3Aug 12, 2025
11 checks passed
@nicolas-grekas
Copy link
Member

And thank you@rvanlaak

rvanlaak reacted with heart emoji

@rvanlaak
Copy link
Contributor

As can be read onsoyuka#2 the 7.3.2 release actually introduced a regression for ObjectMapper, as our CI pipeline was failing on the Renovatebot update PR to that release. As patch releases usually appear once per month, could this edge case regression on the experimental component be considered to be severe enough for an extra patch release in the upcoming days? 🙌

@xabbuh
Copy link
Member

Are there any other changes in 7.3.2 that make it impossible to downgrade to 7.3.1/7.3.0 for the time until 7.3.3 is fixed at the regular schedule?

@rvanlaak
Copy link
Contributor

No. And the BC itself is on an edge case, so scope of the impact is limited.

We solely can not update to 7.3.2 and will stay on 7.3.1 until this PR gets released and our CI will turn green. It's mostly my over-eagerness that's asking that wants to start dropping all the boilerplate code for ObjectMapper implementations.

@xabbuh
Copy link
Member

I guess that's not an important enough reason for an extra release. 😉

rvanlaak reacted with thumbs up emoji

@fabpotfabpot mentioned this pull requestAug 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

5 participants

@soyuka@nicolas-grekas@rvanlaak@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp