NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[Form] Add form type guesser for`EnumType`#61297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.4frommttsch:feature/61272-form-enum-type-guesser

Aug 30, 2025

Merged

[Form] Add form type guesser for`EnumType`#61297

fabpot merged 1 commit intosymfony:7.4frommttsch:feature/61272-form-enum-type-guesser

Aug 30, 2025

Conversation

Copy link

Contributor

mttsch commentedAug 1, 2025

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix#61272
License	MIT

This new form type guesser guesses the form type of an enum property and also sets theclass option of theEnumType to the relevant enum name.

mttsch requested review fromxabbuh andyceruto ascode owners

August 1, 2025 15:55

carsonbot added Status: Needs Review Feature Form labels

Aug 1, 2025

carsonbot added this to the7.4 milestone

Aug 1, 2025

mttsch commented

Aug 1, 2025

View reviewed changes

src/Symfony/Component/Form/EnumFormTypeGuesser.php OutdatedShow resolvedHide resolved

mttsch force-pushed thefeature/61272-form-enum-type-guesser branch 4 times, most recently from30ce63c to0796aa4Compare

August 1, 2025 16:27

This comment was marked as outdated.

mttsch force-pushed thefeature/61272-form-enum-type-guesser branch 2 times, most recently from80d176c to78a2346Compare

August 3, 2025 03:40

nicolas-grekas reviewed

Aug 5, 2025

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Resources/config/form.phpShow resolvedHide resolved

mttsch force-pushed thefeature/61272-form-enum-type-guesser branch 2 times, most recently from1fbb523 toa5eebb2Compare

August 5, 2025 09:53

nicolas-grekas reviewed

Aug 5, 2025

View reviewed changes

src/Symfony/Component/Form/Tests/Fixtures/EnumFormTypeGuesserCase.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Form/Tests/EnumFormTypeGuesserTest.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Form/EnumFormTypeGuesser.phpShow resolvedHide resolved

src/Symfony/Component/Form/EnumFormTypeGuesser.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Form/EnumFormTypeGuesser.php Outdated


		privatefunctiongetPropertyType(string$class,string$property): ?\ReflectionNamedType
		{
		if (isset($this->cache[$class]) &&\array_key_exists($property,$this->cache[$class])) {

Copy link

Member

nicolas-grekasAug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	if (isset($this->cache[$class]) &&\array_key_exists($property,$this->cache[$class])) {
	if (isset($this->cache[$class][$property])) {

src/Symfony/Component/Form/EnumFormTypeGuesser.php Outdated

Comment on lines 57 to 60

		if (!isset($this->cache[$class])) {
		$this->cache[$class] = [];
		}

Copy link

Member

nicolas-grekasAug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	if (!isset($this->cache[$class])) {
	$this->cache[$class] = [];
	}

src/Symfony/Component/Form/EnumFormTypeGuesser.php Outdated

		$classReflection =new \ReflectionClass($class);
		$propertyReflection =$classReflection->getProperty($property);
		}catch (\ReflectionException) {
		return$this->cache[$class][$property] =null;

Copy link

Member

nicolas-grekasAug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	return$this->cache[$class][$property] =null;
	return$this->cache[$class][$property] =false;

src/Symfony/Component/Form/EnumFormTypeGuesser.php Outdated

Comment on lines 62 to 63

		$classReflection =new \ReflectionClass($class);
		$propertyReflection =$classReflection->getProperty($property);

Copy link

Member

nicolas-grekasAug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	$classReflection =new \ReflectionClass($class);
	$propertyReflection =$classReflection->getProperty($property);
	$propertyReflection =new \ReflectionProperty($class,$property);

src/Symfony/Component/Form/EnumFormTypeGuesser.php Outdated

Comment on lines 68 to 72

		if (!$propertyReflection->getType()instanceof \ReflectionNamedType \|\| !enum_exists($propertyReflection->getType()->getName())) {
		return$this->cache[$class][$property] =null;
		}

		return$this->cache[$class][$property] =$propertyReflection->getType();

Copy link

Member

nicolas-grekasAug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	if (!$propertyReflection->getType()instanceof \ReflectionNamedType \|\| !enum_exists($propertyReflection->getType()->getName())) {
	return$this->cache[$class][$property] =null;
	}

	return$this->cache[$class][$property] =$propertyReflection->getType();
	$type =$propertyReflection->getType();

	if (!$typeinstanceof \ReflectionNamedType \|\| !enum_exists($enum->getName())) {
	$type =false;
	}

	return$this->cache[$class][$property] =$type;