Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Add MicrosoftGraph API Transport#61290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.4frombobvandevijver:microsoft-graph-mailer
Aug 6, 2025

Conversation

@bobvandevijver
Copy link
Contributor

QA
Branch?7.4
Bug fix?no
New feature?yes
Deprecations?no
IssuesAlternative for#60408
LicenseMIT

Add a new Mailer bridge for the Microsoft Graph API, but without adding the complete Microsoft SDK as we're talking about just two HTTP POST requests.

I continued the work done in#60408 and kept the names mentioned there in the composer definition, but this implementation has been made from scratch, is based on the existing Azure Bridge and supports more features such as priority and inline attachments.

brandonkelly and zoglo reacted with heart emoji
@bobvandevijver

This comment was marked as resolved.

@MatTheCat
Copy link
Contributor

Don’t know if it’s related but it looks like you forgot to updateregisterMailerConfiguration’s$classToServices in theFrameworkExtension:

bobvandevijver reacted with heart emoji

@bobvandevijver
Copy link
ContributorAuthor

@MatTheCat You are today's hero, thank you!

MatTheCat reacted with laugh emoji

@bobvandevijverbobvandevijverforce-pushed themicrosoft-graph-mailer branch 2 times, most recently from00ecd57 to37f87a2CompareAugust 1, 2025 11:24
@bobvandevijver

This comment was marked as outdated.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, I trust you've tested this against the real thing :)
Here are some nitpicking

bobvandevijver reacted with thumbs up emoji
@bobvandevijver
Copy link
ContributorAuthor

Another test failure, but seems unrelated to the changes here.

}

if (null === $authEndpoint) {
throw new IncompleteDsnException("Transport 'microsoftgraph+api' requires the 'authEndpoint' option when not using the default graph endpoint.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
thrownewIncompleteDsnException("Transport'microsoftgraph+api' requires the'authEndpoint' option when not using the default graph endpoint.");
thrownewIncompleteDsnException('Transport"microsoftgraph+api" requires the"authEndpoint" option when not using the default graph endpoint.');

We are using" quotes in exception messages.

@fabpotfabpotforce-pushed themicrosoft-graph-mailer branch from0fc08d3 to7a1e3fbCompareAugust 6, 2025 18:12
@fabpot
Copy link
Member

Thank you@bobvandevijver.

bobvandevijver reacted with hooray emoji

@fabpotfabpot merged commit0e2dea5 intosymfony:7.4Aug 6, 2025
5 of 12 checks passed
@bobvandevijverbobvandevijver deleted the microsoft-graph-mailer branchAugust 6, 2025 18:13
This was referencedOct 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

7 participants

@bobvandevijver@MatTheCat@fabpot@nicolas-grekas@OskarStark@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp