Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Deprecate XML configuration format#61287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
high-deps failure seems related to#61101; how could it be fixed? |
2422e54 toed71ee6Comparef95c212 toa0ad8e3Comparea0ad8e3 to600e7a3Compare600e7a3 toe08eeeaComparenicolas-grekas added a commit that referenced this pull requestSep 3, 2025
…-time serialization metadata (nicolas-grekas)This PR was merged into the 7.4 branch.Discussion----------[Serializer] Allow using attributes to declare compile-time serialization metadata| Q | A| ------------- | ---| Branch? | 7.4| Bug fix? | no| New feature? | yes| Deprecations? | yes| Issues | -| License | MITVery close to#61528Prerequisite for#61287At the moment, serialization attributes are read at runtime when `framework.serialization.enable_attributes` is true.This means they don't fit for bundles nor can't they be warmed up.This PR fixes both issues by using a new `serializer.attribute_metadata` resource tag, that's turned into a list of classes to parse for attributes at compile-time.For bundles and for apps, the tag is added by explicit service configuration:```php ->set('my_bundle.api_resource.product', Product::class) ->resourceTag('serializer.attribute_metadata')```Unlike validation where we have constraint attributes to auto-discover service resources, serialization doesn't have any corresponding hooks. We do have a few like `#[DiscriminatorMap]` of `#[Groups]`, but relying on those would miss many more classes that are meant for serialization. Maybe we could introduce an attribute that'd hint that some class is serializable by the component (and require the attribute at some point in the future?)Commits-------bc6e054 [Serializer] Allow using attributes to declare compile-time serialization metadata
Let me close for reasons explained in#61288 (comment). |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Split from#60568