Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] deprecate passing choices as$options argument toChoice constraint#61255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.4fromxabbuh:validator-choices
Jul 29, 2025

Conversation

@xabbuh
Copy link
Member

QA
Branch?7.4
Bug fix?no
New feature?no
Deprecations?yes
Issues
LicenseMIT

@carsonbotcarsonbot added this to the7.4 milestoneJul 28, 2025
@xabbuhxabbuhforce-pushed thevalidator-choices branch 2 times, most recently from5e30b16 to78728d4CompareJuly 28, 2025 07:28
@OskarStarkOskarStark changed the title[Validator] deprecate passing choices as $options argument to Choice constraint[Validator] deprecate passing choices as$options argument toChoice constraintJul 29, 2025
@nicolas-grekas
Copy link
Member

That makes me a bit sad, forcing ppl to upgrade to something that's not clearer, just more verbose.
Or is your plan to remove the $options argument in 8.0?

@xabbuh
Copy link
MemberAuthor

This change is needed to be able to throw when$options is notnull in 8.0 (seehttps://github.com/symfony/symfony/pull/61063/files#diff-1139178a1214882355d082c476f13da20d28746a53f307571f5b5dc3571fe347L87). This PR ensures that you are aware and update your code. My ultimate goal is to deprecate the$options arguments of the different constraint classes in 8.1 (doing it earlier is probably a nightmare we cannot solve due to the fact that we cannot simply reorder arguments but also need to take named arguments into account, that will be easier once we know for sure that$options will be nothing else thannull).

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit585e9df intosymfony:7.4Jul 29, 2025
10 of 11 checks passed
@xabbuhxabbuh deleted the validator-choices branchJuly 29, 2025 21:16
This was referencedOct 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SpomkySpomkySpomky approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@nicolas-grekas@Spomky@alexandre-daubois@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp