Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Use unique identifier forRequestContextProvider#61246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ToshY
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#61130
LicenseMIT

Creates unique identifier for vardumper when runningbin/console server:dump /bin/console server:dump --format=html. The fix in theRequestContextProvider now useshash('crc32b') in combination with$_SERVER['REQUEST_TIME_FLOAT'], which is the same as theCliContextProvider.

@carsonbot

This comment has been minimized.

@ToshYToshY changed the base branch from7.4 to6.4July 26, 2025 18:05
@ToshY
Copy link
ContributorAuthor

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "6.4". Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Accidently clicked to fast on create PR. As it's a bug, based and targeted on6.4, so label should be6.4.

bakhoucheYesser reacted with thumbs up emoji

@carsonbotcarsonbot changed the titleUse unique identifier for RequestContextProvider[VarDumper] Use unique identifier for RequestContextProviderJul 26, 2025
@OskarStarkOskarStark modified the milestones:7.4,6.4Jul 26, 2025
@OskarStarkOskarStark changed the title[VarDumper] Use unique identifier for RequestContextProvider[VarDumper] Use unique identifier forRequestContextProviderJul 29, 2025
@ToshYToshYforce-pushed thebug/61130-vardumper-identifier branch froma0e4af9 to46bb36eCompareJuly 29, 2025 18:38
@ToshYToshYforce-pushed thebug/61130-vardumper-identifier branch from46bb36e to73c57e6CompareJuly 29, 2025 18:40
@nicolas-grekas
Copy link
Member

Thank you@ToshY.

ToshY reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitd157aa7 intosymfony:6.4Jul 29, 2025
9 of 10 checks passed
This was referencedJul 31, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@SpomkySpomkySpomky left review comments

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[VarDumper]spl_object_hash($request) is identical leading to hidden information for sections

5 participants

@ToshY@carsonbot@nicolas-grekas@Spomky@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp