Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] [Table] Fix invalid UTF-8 due to text wrapping#61242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromschlndh:fix-bug58286
Jul 30, 2025

Conversation

@schlndh
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58286
LicenseMIT

I changed theOutputFormatter to use string methods fromHelper to avoid splitting multi-byte UTF-8 characters and causing the "Invalid UTF-8" exception as a result. Unfortunately, it turns out thatHelper::length andHelper::substr are not mutually compatible for UTF-8, becauselength returns the length in graphemes, whilesubstr worked with characters. I decided to fix that, which is technically a BC break (hopefully not too severe). I considered making a private fixed copy of the method, but that just seemed weird.

voku reacted with thumbs up emoji
@schlndhschlndh requested a review fromchalasr as acode ownerJuly 26, 2025 08:25
@carsonbotcarsonbot added this to the6.4 milestoneJul 26, 2025
@carsonbotcarsonbot changed the title[Console][Table] Fix invalid UTF-8 due to text wrapping[Console] [Table] Fix invalid UTF-8 due to text wrappingJul 26, 2025
@schlndhschlndhforce-pushed thefix-bug58286 branch 3 times, most recently from69eddce to932287fCompareJuly 26, 2025 09:00
@schlndh
Copy link
ContributorAuthor

Fabbot wants me to change a line unrelated to my PR. I'm ignoring it.

OskarStark reacted with thumbs up emoji

schlndh added a commit to schlndh/phpstan-src that referenced this pull requestJul 26, 2025
The patch is fromsymfony/symfony#61242 rebasedonto symfony/console 5.4
ondrejmirtes pushed a commit to phpstan/phpstan-src that referenced this pull requestJul 26, 2025
The patch is fromsymfony/symfony#61242 rebasedonto symfony/console 5.4
@OskarStarkOskarStark changed the title[Console] [Table] Fix invalid UTF-8 due to text wrapping[Console][Table] Fix invalid UTF-8 due to text wrappingJul 27, 2025
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(fabbot's suggestion is a false-positive)

schlndh reacted with thumbs up emoji
@carsonbotcarsonbot changed the title[Console][Table] Fix invalid UTF-8 due to text wrapping[Console] [Table] Fix invalid UTF-8 due to text wrappingJul 29, 2025
@symfonysymfony deleted a comment fromcarsonbotJul 29, 2025
@nicolas-grekas
Copy link
Member

Thank you@schlndh.

schlndh reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit1b7d5c8 intosymfony:6.4Jul 30, 2025
9 of 11 checks passed
@schlndhschlndh deleted the fix-bug58286 branchJuly 30, 2025 09:43
@fabpotfabpot mentioned this pull requestJul 31, 2025
This was referencedJul 31, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@schlndh@nicolas-grekas@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp