Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer][Brevo] Update Webhook IPs#61223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Regarding official Brevo documentation the IP range for webhook changedhttps://help.brevo.com/hc/en-us/articles/15127404548498-Brevo-IP-ranges-List-of-publicly-exposed-services
carsonbot commentedJul 24, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks good to me (see also#61062 (comment))
xabbuh commentedJul 24, 2025
Thank you@jarbey. |
39ff860 intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
| // https://help.brevo.com/hc/en-us/articles/15127404548498-Brevo-IP-ranges-List-of-publicly-exposed-services | ||
| // localhost is added for testing | ||
| newIpsRequestMatcher(['185.107.232.1/24','1.179.112.1/20','172.246.240.1/20','127.0.0.1']), | ||
| newIpsRequestMatcher(['1.179.112.0/20','172.246.240.0/20','127.0.0.1']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is xx.xx.xx.0/20 not the same as xx.xx.xx.1/20 in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is, but it's uncommon to use something else than.0 when using CIDR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably the same but i was not sure. It also removes an old CIDR not used anymore by Brevo => 185.107.232.1/24 to comply with their last update (22 June 2024 if we trust :https://web.archive.org/web/20250622174648/https://help.brevo.com/hc/en-us/articles/15127404548498-Brevo-IP-ranges-List-of-publicly-exposed-services)
Brevo documentation :https://help.brevo.com/hc/en-us/articles/15127404548498-Brevo-IP-ranges-List-of-publicly-exposed-services
Their AS and RIPE Bloc (probably not up to date as it's mention 1.179.120.0/21 :https://ipinfo.io/AS200484#block-ranges)
Regarding official Brevo documentation the IP range for webhook changed
Source :https://help.brevo.com/hc/en-us/articles/15127404548498-Brevo-IP-ranges-List-of-publicly-exposed-services
Should also be applied on 7.3 version
Thank you so much for your hard work Symfony team ♥