Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] fix compatibility with different Relay versions#61220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJul 23, 2025
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
| foreach ((new \ReflectionClass(RelayProxy::class))->getMethods()as$method) { | ||
| if ('reset' ===$method->name ||method_exists(LazyProxyTrait::class,$method->name) ||$method->isStatic()) { | ||
| if ('reset' ===$method->name ||method_exists(LazyProxyTrait::class,$method->name) ||$method->isInternal()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this comes fromhttps://github.com/symfony/symfony/pull/61072/files#diff-e1e9fccaf83eb89ef46c617ca14fb6c05d878f4da528a634aa7d8f414a209f33 where I improved the sync script but didn't backport 😬
nicolas-grekas commentedJul 24, 2025
Thank you@xabbuh. |
3261116 intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.