Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Add #[\NoDiscard] attribute to UriSigner check methods#61147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Conversation
carsonbot commentedJul 17, 2025
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.4 for features / 6.4, 7.2, or 7.3 for bug fixes". Cheers! Carsonbot |
I wrote my opinion on#60429 (comment) before:
|
alexander-schranz commentedJul 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I see, never thought about have them on wither methods, as I maybe not personally fan of that pattern 😆. For me it really only thought it handy for |
Uh oh!
There was an error while loading.Please reload this page.
There are sure more services which may be interesting but want to start with this one to discuss if we adopt:
https://wiki.php.net/rfc/marking_return_value_as_important
In the symfony workspace.
As I know there is nothing wrong to add a attribute which may not exist at that PHP version which we already had in the past with the ReturnTypeWillChange attributes.