Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Console] Fix PHP deprecation when question value isnull#61123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Conversation
Fix testFix another 2 deprecationsFix testFix test
Not sure if I have to fix the fabbot.io error, because I didn't change that line. |
nullIn the issue itself, you say yourselves
I think you should rather fix your code to avoid passing |
IIUC from the issue |
@stof I understand, but probably in PHP 8 you will get an error instead of a deprecation and developers might think the problem is in the Symfony core. But now I think more about this, maybe it's better to check if the value is a string or is stringable, otherwise throw an exception with "Must be string or stringable"? Didn't check, but probably you can also pass a integer (that will work as long as isn't strict), object or array. |
Add nullsafe and add NULL to test to catch the PHP deprecation.