NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[FrameworkBundle] Fix cache warmers tests#61101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

MatTheCat wants to merge1 commit intosymfony:7.3

base:7.3

Choose a base branch

fromMatTheCat:cache_warmer_tests

Open

[FrameworkBundle] Fix cache warmers tests#61101

MatTheCat wants to merge1 commit intosymfony:7.3fromMatTheCat:cache_warmer_tests

+45 −11

Conversation

Copy link

Contributor

MatTheCat commentedJul 11, 2025•
edited
Loading

Q	A
Branch?	7.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	N/A
License	MIT

While updating tests for#60568 I sawSerializerCacheWarmerTest andValidatorCacheWarmerTest’stestWarmUpWithoutBuilDir fail. Since there will be no warm up without a build directory it was weird a cache item could get hit in that case.

Turns out that was because thePhpArrayAdapter’s$valuesCache would retain them from previous tests.

This PR adds agetArrayPool method to the test cases which allows them to clear it on tearDown, so that tests don’t impact each other. Alternatively they could clear their own adapter or pass it different files, but this seemed the safest approach to me.