Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Serializer] [ObjectNormalizer] Fix isser methods where the property has the same name#61097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Conversation
carsonbot commentedJul 10, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
…IsserMethodWithSameName test class
RafaelKr commentedJul 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Another Edge-CaseAfter I just found#61023 I also tried having properties and getter methods called class ObjectWithBooleanPropertyAndIsserWithSameName{private$foo ='foo';private$isFoo =true;private$canFoo =false;publicfunctionisFoo() {return$this->isFoo; }publicfunctioncanFoo() {return$this->canFoo; }} This results in ['isFoo' =>true,'foo' =>true,// it's using the isFoo isser method!] Notice, that for the Reading through the linked PR I wonder if my PR also classifies as "new feature" instead of "bugfix"? |
RafaelKr commentedJul 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Extended Edge-Caseclass ObjectWithBooleanPropertyAndIsserWithSameName{public$foo ='foo';private$getFoo ='getFoo';private$hasFoo ='hasFoo';private$canFoo ='canFoo';private$isFoo ='isFoo';publicfunctiongetFoo() {return$this->getFoo; }publicfunctionhasFoo() {return$this->hasFoo; }publicfunctioncanFoo() {return$this->canFoo; }publicfunctionisFoo() {return$this->isFoo; }} Results in ['foo' =>'getFoo','isFoo' =>'isFoo'] So we may also want to add the That would result in: ['getFoo' =>'getFoo','hasFoo' =>'hasFoo','canFoo' =>'canFoo','isFoo' =>'isFoo','foo' =>'getFoo'] |
Uh oh!
There was an error while loading.Please reload this page.
Notes
Although technically this is a bugfix and its pretty much an edge-case, this may affect existing projects and may alter their serialization results. So it could be a breaking change.
Edit: Also see comments below for further edge cases.
Before/After comparison
Before this PR
It was normalized as:
Removing the
$owner
property and getters would result in:After this PR
It will be normalized as: