Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] [ObjectNormalizer] Fix isser methods where the property has the same name#61097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
RafaelKr wants to merge2 commits intosymfony:6.4
base:6.4
Choose a base branch
Loading
fromRafaelKr:fix_61096

Conversation

RafaelKr
Copy link

@RafaelKrRafaelKr commentedJul 10, 2025
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#61096
LicenseMIT

Notes

Although technically this is a bugfix and its pretty much an edge-case, this may affect existing projects and may alter their serialization results. So it could be a breaking change.

Edit: Also see comments below for further edge cases.

Before/After comparison

class MyClass {privatestring$owner ='foo';privatebool$isOwner =true;publicfunctiongetOwner():string {return$this->owner;  }publicfunctionsetOwner(string$owner):void {$this->owner =$owner;  }publicfunctionisOwner():bool {return$this->isOwner;  }publicfunctionsetIsOwner(bool$isOwner):void {$this->isOwner =$isOwner;  }}$classMetadataFactory =newClassMetadataFactory(newAttributeLoader());$normalizer =newObjectNormalizer($classMetadataFactory);$object =newMyClass();$normalized =$normalizer->normalize($object);

Before this PR

It was normalized as:

['owner' =>'foo',]

Removing the$owner property and getters would result in:

['owner' =>true,]

After this PR

It will be normalized as:

['owner' =>'foo','isOwner'  =>true,]

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Serializer][ObjectNormalizer] Fix isser methods where the property has the same name[Serializer] [ObjectNormalizer] Fix isser methods where the property has the same nameJul 10, 2025
@RafaelKr
Copy link
Author

RafaelKr commentedJul 10, 2025
edited
Loading

Another Edge-Case

After I just found#61023 I also tried having properties and getter methods calledisFoo andcanFoo (nogetFoo at this time) in theObjectWithBooleanPropertyAndIsserWithSameName class:

class ObjectWithBooleanPropertyAndIsserWithSameName{private$foo ='foo';private$isFoo =true;private$canFoo =false;publicfunctionisFoo()    {return$this->isFoo;    }publicfunctioncanFoo()    {return$this->canFoo;    }}

This results in

['isFoo' =>true,'foo' =>true,// it's using the isFoo isser method!]

Notice, that for thecanFoo property it's using theisFoo method to get the value and printsfoo as result name.

Reading through the linked PR I wonder if my PR also classifies as "new feature" instead of "bugfix"?
cc@nicolas-grekas

@RafaelKr
Copy link
Author

RafaelKr commentedJul 10, 2025
edited
Loading

Extended Edge-Case

class ObjectWithBooleanPropertyAndIsserWithSameName{public$foo ='foo';private$getFoo ='getFoo';private$hasFoo ='hasFoo';private$canFoo ='canFoo';private$isFoo ='isFoo';publicfunctiongetFoo()    {return$this->getFoo;    }publicfunctionhasFoo()    {return$this->hasFoo;    }publicfunctioncanFoo()    {return$this->canFoo;    }publicfunctionisFoo()    {return$this->isFoo;    }}

Results in

['foo' =>'getFoo','isFoo' =>'isFoo']

So we may also want to add the$reflClass->hasProperty($name) check I added for issers forget,has andcan?

That would result in:

['getFoo' =>'getFoo','hasFoo' =>'hasFoo','canFoo' =>'canFoo','isFoo' =>'isFoo','foo' =>'getFoo']

@RafaelKrRafaelKr marked this pull request as draftJuly 10, 2025 15:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

2 participants
@RafaelKr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp