Movatterモバイル変換

Skip to content

symfony/symfonyPublic

NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Console] Fix`TreeHelper::addChild` when providing a string#61080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

jtattevin wants to merge3 commits intosymfony:7.3

base:7.3

Choose a base branch

fromjtattevin:ConsoleFixTreeHelper

Open

[Console] Fix`TreeHelper::addChild` when providing a string#61080

jtattevin wants to merge3 commits intosymfony:7.3fromjtattevin:ConsoleFixTreeHelper

Conversation

jtattevin

Copy link

jtattevin commentedJul 9, 2025•
edited by OskarStark
Loading

Q	A
Branch?	7.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	--
License	MIT

When using the tree helper, the method addChild allow to pass a string instead of an instance of TreeNode, for example :

$rootNode =newTreeNode('Root');$rootNode->addChild('Child 1');$rootNode->addChild('Child 2');$rootNode->addChild('Child 3');$tree = TreeHelper::createTree($output,$rootNode);$tree->render();

This method was creating the TreeNode from the string and using the parent as the children iterator, leading to an error likeLogicException: Cycle detected at node: "Child 1"

This commit remove this second parameter.

@jtattevin

[Console] Fix TreeHelper::addChild when providing a string

60f3e63

@jtattevin

jtattevin requested a review fromchalasr as acode owner

July 9, 2025 12:00

@carsonbot

carsonbot added Status: Needs Review Bug Console labels

@carsonbot

carsonbot added this to the7.3 milestone

@chalasr

Copy link

Member

chalasr commentedJul 9, 2025

@smnandre

Copy link

Member

smnandre commentedJul 9, 2025

Oops... I missed that, indeed 😶

PR seems very legit 👍

That said, I think it'd be better to add a new test inTreeNodeTest, since this isn’t really the Helper’s responsibility here..

(and I realize there’s currently no test that simply does $node->addChild('string') in TreeNodeTest ... re 😶 )

jtattevin added2 commits

July 10, 2025 08:27

@jtattevin

Add unit test on TreeNode directly

80fa7a8

@jtattevin

Add unit test on TreeNode directly

d03c4fa

@jtattevin

Copy link

Author

jtattevin commentedJul 10, 2025

I've added the test in TreeNodeTest and also checked that the content is used correctly.

I've kept the test in the helper since it's the visible issue, but I can remove it if it's too redundant.

@OskarStark

OskarStark changed the title~~[Console] Fix TreeHelper::addChild when providing a string~~[Console] FixTreeHelper::addChild when providing a string

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Bug Console Status: Needs Review

4 participants

@jtattevin

@chalasr

@smnandre

@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp