Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Skip windows x86 number transformer test#61055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@OskarStark
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Issues#60975
LicenseMIT

Follows#60975 (comment)

@carsonbot

This comment was marked as outdated.

@OskarStark
Copy link
ContributorAuthor

OskarStark commentedJul 7, 2025•
edited
Loading

Hmm, seems that the 32bit number is now to low to not be rounded.

1) Symfony\Component\Form\Tests\Extension\Core\DataTransformer\NumberToLocalizedStringTransformerTest::testReverseTransformDoesNotCauseIntegerPrecisionLossFailed asserting that 2147483646.0 is identical to 2147483646.

any idea?@xabbuh shall we just skip this test on 32bit?

@OskarStarkOskarStark changed the title[Form] Fix windows x86 number transformer test[Form] Skip windows x86 number transformer testJul 7, 2025
@OskarStarkOskarStarkforce-pushed thefix-windows-x86-number-transformer-test branch from4d58ecc toba28b51CompareJuly 7, 2025 11:53
@OskarStark
Copy link
ContributorAuthor

ready to merge

@nicolas-grekasnicolas-grekasforce-pushed thefix-windows-x86-number-transformer-test branch fromd9b603a toa426cddCompareJuly 7, 2025 12:41
@nicolas-grekas
Copy link
Member

Thank you@OskarStark.

OskarStark reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit7d1b50a intosymfony:6.4Jul 7, 2025
10 of 11 checks passed
@OskarStarkOskarStark deleted the fix-windows-x86-number-transformer-test branchJuly 7, 2025 12:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@OskarStark@carsonbot@nicolas-grekas@stof
[8]ページ先頭
©2009-2025 Movatter.jp