Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Intl] Remove deprecatedEmojiTransliterator#60986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:8.0frommttsch:feature/EmojiTransliterator
Jul 2, 2025

Conversation

@mttsch
Copy link
Contributor

QA
Branch?8.0
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT

@mttsch
Copy link
ContributorAuthor

mttsch commentedJun 30, 2025
edited
Loading

Symfony docs do not need an update because they already use class from the emoji component.

@mttschmttschforce-pushed thefeature/EmojiTransliterator branch from5ac3ea2 to009248dCompareJune 30, 2025 16:59
@mttschmttschforce-pushed thefeature/EmojiTransliterator branch from009248d tob01708bCompareJune 30, 2025 17:08
@mttschmttsch changed the title[Intl] Remove deprecated EmojiTransliterator[Intl] Remove deprecatedEmojiTransliteratorJun 30, 2025
@mttschmttschforce-pushed thefeature/EmojiTransliterator branch fromb01708b toebfd7a8CompareJune 30, 2025 18:26
Intl
----

* Remove`Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use`Symfony\Component\Emoji\EmojiTransliterator` instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
* Remove`Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use`Symfony\Component\Emoji\EmojiTransliterator` instead
* Remove`EmojiTransliterator`, use`Symfony\Component\Emoji\EmojiTransliterator` instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I asked explicitly for the FQCN, as I find it hard to spot the difference, as the classname stays the same

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@xabbuh@OskarStark Can you discuss the issue among yourselves and then tell me which one is the final one I should use. I like to avoid going back and forth unnecessarily :)

8.0
---

* Remove`Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use`Symfony\Component\Emoji\EmojiTransliterator` instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
* Remove`Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use`Symfony\Component\Emoji\EmojiTransliterator` instead
* Remove`EmojiTransliterator`, use`Symfony\Component\Emoji\EmojiTransliterator` instead

@fabpot
Copy link
Member

Thank you@mttsch.

@fabpotfabpot merged commit704572a intosymfony:8.0Jul 2, 2025
4 of 9 checks passed
@welcoMatticwelcoMattic added the BC Layer removalUsed to track BC layer removals before a major release labelJul 4, 2025
@fabpotfabpot mentioned this pull requestOct 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Labels

BC Layer removalUsed to track BC layer removals before a major releaseFeatureIntlStatus: Reviewed

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

7 participants

@mttsch@fabpot@stof@OskarStark@xabbuh@welcoMattic@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp