Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Fix precision loss when rounding large integers inNumberToLocalizedStringTransformer#60975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@OskarStark
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#60947
LicenseMIT

mhbailly reacted with heart emoji
@carsonbotcarsonbot added this to the6.4 milestoneJun 30, 2025
@carsonbotcarsonbot changed the titleFix precision loss when rounding large integers inNumberToLocalizedStringTransformer[Form] Fix precision loss when rounding large integers inNumberToLocalizedStringTransformerJun 30, 2025
…StringTransformer`Add type check in `round()` method to bypass rounding for integer values,preventing precision loss for large integers that are still below PHP_INT_MAX.🤖 Generated with [Claude Code](https://claude.ai/code)
@OskarStarkOskarStarkforce-pushed thefix-number-transformer-precision-6.4 branch fromdca4cfb tobf312d3CompareJuly 1, 2025 18:07
@OskarStark
Copy link
ContributorAuthor

Failure looks unrelated

@nicolas-grekas
Copy link
Member

Thank you@OskarStark.

@nicolas-grekasnicolas-grekas merged commit4f5545b intosymfony:6.4Jul 7, 2025
9 of 11 checks passed
@nicolas-grekas
Copy link
Member

Sorry I missed that before merge: this breaks on x86, see the windows build.

@OskarStarkOskarStark deleted the fix-number-transformer-precision-6.4 branchJuly 7, 2025 10:36
@OskarStark
Copy link
ContributorAuthor

I think#61055 should fix it@nicolas-grekas

nicolas-grekas added a commit that referenced this pull requestJul 7, 2025
…ark)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Form] Skip windows x86 number transformer test| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        |#60975| License       | MITFollows#60975 (comment)Commits-------a426cdd [Form] Skip windows x86 number transformer test
This was referencedJul 31, 2025
GromNaN added a commit that referenced this pull requestSep 20, 2025
…bbuh)This PR was merged into the 6.4 branch.Discussion----------[Form] prefer the public API over reflection in test| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITI missed this in#60975Commits-------baaa7d0 prefer the public API over reflection in test
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

1 more reviewer

@mhbaillymhbaillymhbailly left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@OskarStark@nicolas-grekas@mhbailly@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp