Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] remove return type fromAbstractObjectNormalizer::getAllowedAttributes()#60958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedJun 30, 2025
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix#60957 |
| License | MIT |
mtarld approved these changesJun 30, 2025
AbstractObjectNormalizer::getAllowedAttributes()HypeMC approved these changesJun 30, 2025
stof approved these changesJun 30, 2025
Member
stof commentedJun 30, 2025
will need to be reverted in the 8.0 branch |
bd60612 intosymfony:6.4 9 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Contributor
OskarStark commentedJun 30, 2025
do you create a PR@xabbuh ? |
MemberAuthor
xabbuh commentedJun 30, 2025
yes |
MemberAuthor
xabbuh commentedJul 1, 2025
reverted in0fdec91 when merging up |
santysisi pushed a commit to santysisi/symfony that referenced this pull requestJul 2, 2025
…tNormalizer::getAllowedAttributes()` (xabbuh)This PR was merged into the 6.4 branch.Discussion----------[Serializer] remove return type from `AbstractObjectNormalizer::getAllowedAttributes()`| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fixsymfony#60957| License | MITCommits-------b58fa26 remove return type from AbstractObjectNormalizer::getAllowedAttributes()
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull requestJul 7, 2025
This was referencedJul 31, 2025
Merged
Merged
Merged
TheMilek added a commit to Sylius/Sylius that referenced this pull requestAug 20, 2025
| Q | A|-----------------|-----| Branch? | 1.14| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Related tickets |#18195 | License | MITThe bug raised in#18195 as been revert in symfony/serializer in 6.4.24(cfsymfony/symfony#60958)I guess we can target the conflict only on 6.4.23 now.
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.