Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpKernel] Avoid memory leaks cache attribute, profiler listener#60934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
andrew-demb wants to merge3 commits intosymfony:7.4Choose a base branch
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[HttpKernel] Avoid memory leaks cache attribute, profiler listener#60934
andrew-demb wants to merge3 commits intosymfony:7.4fromandrew-demb:avoid-memory-leaks-cache-attribute
+28 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a3367a0 to5996644CompareCI failure is unrelated |
Introducing an new method means this is a new feature, it should target 7.4 |
| @@ -4,6 +4,7 @@ CHANGELOG | |||
| 6.4 | |||
| --- | |||
| * `Symfony\Component\HttpKernel\EventListener\CacheAttributeListener` is now resettable to prevent memory leaks | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| *`Symfony\Component\HttpKernel\EventListener\CacheAttributeListener` is now resettable to prevent memory leaks | |
| *`Symfony\Component\HttpKernel\EventListener\CacheAttributeListener` is now resettable to prevent memory leaks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed, thanks
5996644 to2e51bdcCompare2e51bdc toa7c7c72CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
For the current moment, if the
onKernelTerminate/onKernelResponsemethods won't be called, the listener's state won't be reset between requests.Please let me know if this should be considered as a new feature - to retarget PR to the 7.3 branchSimilar to PR#60933