Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[SecurityBundle] Remove deprecated OIDC token handler optionsalgorithm andkey#60929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:8.0
Are you sure you want to change the base?
Conversation
OskarStark commentedJun 27, 2025
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
| ->ifTrue(staticfn ($v) => !isset($v['algorithms'])) | ||
| ->thenInvalid('You must set "algorithms".') |
OskarStarkJun 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this can be removed, right? Asalgorithms is marked withisRequired()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think so yes
you might want to verify on a proto app of course
d4eb6c2 to3b3362fCompare…hm and keyRemove the deprecated algorithm and key options from the OIDC token handler configuration,use algorithms and keyset instead.- Add CHANGELOG entry- Add UPGRADE-8.0.md entry with before/after examples- Remove legacy test for deprecated options- No need to remove symfony/deprecation-contracts (not present)
3b3362f to3ae1f9fCompareUPGRADE-8.0.md Outdated
| access_token: | ||
| token_handler: | ||
| oidc: | ||
| algorithms: ['RS256'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a diff instead of a before/after would be more appropriate I think
| # config/packages/security.yaml | ||
| security: | ||
| firewalls: | ||
| main: | ||
| access_token: | ||
| token_handler: | ||
| oidc: | ||
| - algorithm: 'RS256' | ||
| - key: 'https://example.com/.well-known/jwks.json' | ||
| + algorithms: ['RS256'] | ||
| + keyset: 'https://example.com/.well-known/jwks.json' | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
in a diff, non modified lines must start with an extra space (instead if a + / - for changed lines):
| #config/packages/security.yaml | |
| security: | |
| firewalls: | |
| main: | |
| access_token: | |
| token_handler: | |
| oidc: | |
| - algorithm: 'RS256' | |
| - key: 'https://example.com/.well-known/jwks.json' | |
| + algorithms: ['RS256'] | |
| + keyset: 'https://example.com/.well-known/jwks.json' | |
| ``` | |
| # config/packages/security.yaml | |
| security: | |
| firewalls: | |
| main: | |
| access_token: | |
| token_handler: | |
| oidc: | |
| - algorithm: 'RS256' | |
| - key: 'https://example.com/.well-known/jwks.json' | |
| + algorithms: ['RS256'] | |
| + keyset: 'https://example.com/.well-known/jwks.json' |