Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Templating] Added ability to set a specific version of the asset#6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@hason
Copy link
Contributor

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

whyfalse ?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If you want to disable generating versioned url.

@fabpot
Copy link
Member

@hason: What is your use case?

@hason
Copy link
ContributorAuthor

First use case: I want to generate a path to the directory (eg. themes for jsTree)

$.jstree._themes={{asset("PATH/TO/FOLDER/",null,false)|json_encode}};

Second use case: I want to set a specific version of the asset (eg. regenerate every day):

{{ asset("path/to/asset", null, "now"|date("mdY")) }}

@fabpot
Copy link
Member

Ok, you've just described what the change does, and I understood that. But why would you want to set a specific version for the assets? I cannot think of a real-world use case for that.

@hason
Copy link
ContributorAuthor

Ok, how we make the first real use case (a path to the directory without?<asset_version> suffix)? The same case is to set the path to the images for amcharts:

varAMCHARTS_PATH_TO_IMAGES={{asset("@amcharts/amcharts/amcharts/images/",null,false)|json_encode|raw}};

And yes I want rather local shutdown versioning.

@fabpot
Copy link
Member

closing in favor of#10593

@fabpotfabpot closed thisMar 31, 2014
fabpot added a commit that referenced this pull requestMar 31, 2014
…f the asset (romainneutron)This PR was merged into the 2.5-dev branch.Discussion----------[Templating] Added ability to set a specific version of the asset| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MIT| Doc PR        |https://github.com/symfony/symfony-docs/pull/3742/filesThis PR replaces#6092Commits-------1642094 [Templating] Update changelog6fce503 [Templating] Added ability to set a specific version of the asset
@fabpotfabpot mentioned this pull requestJan 5, 2015
1 task
@hasonhason deleted the asset_version branchJanuary 7, 2015 15:18
fabpot added a commit that referenced this pull requestFeb 10, 2015
This PR was merged into the 2.7 branch.Discussion----------[Asset] added the component| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#10973,#11748,#11876,#4883,#12474| License       | MIT| Doc PR        | not yetTODO: - [ ] submit documentation PRThe current Asset sub-namespace in Templating has several (major) problems: * It does not cover all use cases (see#10973 and#4883 for some example) * It has some design issues (relies on the Request instance and so requires the request scope, very coupled with the PHP templating sub-system, see#11748 and#11876)To decouple this feature and make it reusable in Silex for instance, and to fix the design issues and make it more extensible, I've decided to extract and rework the features provided into a new Asset component.Basically, this component allows the developer to easily manage asset URLs: versioning, paths, and hosts.Both the new and the old asset management features are kept in this PR to avoid breaking BC; the old system is of course deprecated and automatically converted to the new one.Even if the features are quite similar, and besides the flexilibity of the new system, here are some differences: * `PathPackage` always prepend the path (even if the given path starts with `/`). * Usage is stricter (for instance, `PathPackage` requires a basePath to be passed and `UrlPackage` requires that at least on URL is passed). * In the configuration, named packages inherits from the version and version format of the default package by default. * It is not possible to override the version when asking for a URL (instead, you can define your own version strategy implementation -- the use cases explained in#6092 are easily implemented this way). * It's not possible to generate absolute URLs (see#13264 for a better alternative using composition; so using `absolute_url(asset_path('me.png')) should work)`.#10973 was about adding shortcuts for bundles, which is a good idea; but given that you rarely reference built-in or third-party bundle assets and because we now have a one-bundle default approach named AppBundle, the same can be achieved with just a simple piece of configuration with the new assets feature:```ymlframework:    assets:        packages:            app:                base_path: /bundles/app/            img:                base_path: /bundles/app/images/```Then:```jinja{{ asset('images/me.png', 'app') }}# /bundles/app/images/me.png{{ asset('me.png', 'img') }}# /bundles/app/images/me.png```#12474 discussed the possibility to add a version for absolute URL. It's not possible to do that in a generic way as the version strategy involves both the version and the path, which obviously cannot work when the path is an absolute URL already. Instead, one should use the `asset_version` Twig function to add the version manually.Commits-------0750d02 removed usage of the deprecated forms of asset() in the core frameworkf74a1f2 renamed asset_path() to asset() and added a BC layer4d0adea [Asset] added a NullContext classd33c41d [Asset] added the component
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hason@fabpot@stof

[8]ページ先頭

©2009-2025 Movatter.jp